Justin Sternberg

Results 250 comments of Justin Sternberg

I think the answer here would be the same as the one on https://github.com/jtsternberg/Shortcode_Button/issues/16#issuecomment-282761580

What do you get when you: ``` php echo ': '. print_r( Taxonomy_MetaData::get( 'product_cat', $cat->term_id ), true ) .''; ```

Fixed in 3b8e9d9139931851b0fc6a8c670363a67a6b63f7. Those reporting the bug, please update and test.

@sb-lc the get method for the CMB2 abstraction did not work the same way but [I have fixed it](https://github.com/jtsternberg/Taxonomy_MetaData/commit/42b3147bd8027af996eb3c060223987a9cb164fb). But it's unusual and unlikely that you would want to use...

Sounds like you haven't actually included CMB2 then. You can [see in the example](https://github.com/jtsternberg/Taxonomy_MetaData#to-use-taxonomy_metadata-with-cmb2) that that is the first thing that should happen. Alternatively you can install/activate the plugin: [https://wordpress.org/plugins/cmb2](https://wordpress.org/plugins/cmb2/).

When are you calling the getter function? I'm curious why you would need taxonomy meta values before init.

Yes, that is a sane request. I think it's worth deliberation what is a better default.. to have the fields in the add-new area, or not? Re: filter, seems it...

get_fields_for_add_new method should probably still return a filtered value. ``` php ... public function set_fields_for_add_new( $fields ) { $this->add_new_fields = $fields; } public function get_fields_for_add_new() { return apply_filters( "taxonomy_metadata_{$this->taxonomy}_add_form_fields", $this->add_new_fields,...

Can either of you test [after this change](https://github.com/WebDevStudios/CMB2-Date-Range-Field/commit/94256053f4d2f095abe16a83f48f128a2e3fdbdc)?

This is probably all you need: http://jtsternberg.github.io/wp-lib-loader/ Let me know if you have questions.