Justin Sternberg
Justin Sternberg
Just throwing that in here as I would really like to see submodule deployment support. :)
@scttnlsn Curious if you've had any thought towards incorporating submodules to the deployment?
@scttnlsn I fully understand that sentiment! I may try to get my hands dirty if I ever a) get the free-time, or b) have the dying-need. :)
Agreed. Separate.
Good question. 1st, the dockerunit file file is no longer used, so should be deleted. To run tests locally, first, you need to run this script to install the test...
Great! in keeping w/ the github recommendations, let's instead put the instructions in a CONTRIBUTING.md file, and link to that from the readme.
Reviewing now
Ok, I pushed some updates to the [`testing-instructions`](https://github.com/jtsternberg/DsgnWrks-Instagram-Importer/tree/testing-instructions) branch. Please pull those down, and re-run `composer install`. Once that's complete, try running `tests/bin/phpunit` (or `php tests/bin/phpunit`). Both of those should...
Ok, can you try running these exactly? This should remove any previous test installs ```bash rm -rf /tmp/wordpress/ ``` This should reinstall it, and the DB for testing ```bash bash...
Oh, also, related to your question about the logic in those lines for the installer, I just pushed an update to properly check if those directories exist.