Jeremy Tuloup

Results 2209 comments of Jeremy Tuloup

> I don't feel comfortable with exposing the full file path to the frontend Similar feeling at first, without checking if it would be real security issue. Otherwise, have you...

Ah looks like CI is broken on other PRs too, for example https://github.com/voila-dashboards/voila/pull/1478. Stopping for now, may come back to it later with more CI energy. In the meantime if...

Looks nice, thanks @Meriem-BenIsmail for working on this! Maybe a question for later, but it could be interesting to start thinking about what the UI should show if we later...

For reference trying to use the template with `voici` (which is based on Voila 0.5.0) leads to the following error: ![image](https://user-images.githubusercontent.com/591645/231750541-54144ce3-a627-48ac-a585-820031dd224d.png) This was noticed in https://github.com/voila-dashboards/voici/pull/60.

https://github.com/jupyterlite/pyodide-kernel/pull/231 confirmed the issue with the prod build and reverted the `terser` update for now. We should look into a proper fix compatible with newer versions of `terser` and `webpack`.

> We should look into a proper fix compatible with newer versions of terser and webpack. Adding the following to https://github.com/jupyterlite/pyodide-kernel/blob/main/packages/pyodide-kernel-extension/webpack.config.js will likely help: ```ts experiments: { outputModule: true, },...

Linking to an upstream issue where this was discussed: https://github.com/jupyterlab/jupyterlab/issues/10197

Not necessarily in this PR, but maybe it would also be useful to add these values to the Advanced Plugin Manager, for example in a new column? So plugins could...

@Darshan808 @krassowski just checking if you would like to have this in the 4.5.1 release?

For reference the `jupyterlab` assets also seem to have become larger over time: ![image](https://github.com/jupyterlite/jupyterlite/assets/591645/d0719129-edd5-4438-9a8f-662fa86d24a9) ![image](https://github.com/jupyterlite/jupyterlite/assets/591645/377c1b7c-3f38-409c-a69a-8a98036bf7f1)