Jeremy Tuloup

Results 2209 comments of Jeremy Tuloup

@krassowski if you would like to give this a try (or anyone else), feel free to comment here and / or open a new PR, thanks!

Thanks @ArturoAmorQ for the report 👍 Looks like it's specific to the Pyodide kernel repo, so moving the issue over there: https://github.com/jupyterlite/pyodide-kernel

> Looks like I [needed `jupyterlab_server` (but only had `jupyter_server`) as a build dependency](https://github.com/posita/dyce-notebooks/commit/883d3c50db3a2b59dc07fc16e676b26c5af61a45#diff-fefb2e8eecd362019729766b0bea79e46ed583b2e5b0af47dde7700c7c021a02). Is that documented somewhere prominently? ~Right, there is a bit of documentation about this in https://jupyterlite.readthedocs.io/en/stable/reference/cli.html#addon-dependencies....

Right, `content-visibility` track sounds attractive, especially if it ends up simplifying the logic considerably. Also according to https://github.com/jupyterlab/jupyterlab/issues/16327#issuecomment-2432858236 it could be introduced in a 4.x release as a non-breaking change....

> But I think the error should not be thrown if "@jupyterlite/application-extension:service-worker-manager" is not loaded. Indeed, it should be possible to not use the Service Worker in JupyterLite. Also it...

Normally the kernels have tests for accessing contents when cross origin isolated, or when using the service worker. But maybe they are lacking a test to make sure JupyterLite is...

The `win-dev` check does not seem related (also failing on https://github.com/jupyterlite/jupyterlite/pull/1674).

> the CI failure is happening. This test closes the notebook before the page gets reloaded: https://github.com/jupyterlite/jupyterlite/blob/53d740bbd2628bdfaadc0f63a05e0d8fb766852f/ui-tests/test/contents.spec.ts#L374 But on the video we see the notebook is restored on startup: [jupyterlite-close-notebook-refresh.webm](https://github.com/user-attachments/assets/da85626f-151d-49cc-a296-9b6c5ae3e83c)...

> Waiting a couple of seconds before refreshing the page seems to be helping though, and the notebook is not restored after the page is reloaded: It's probably because of...