Jeremy Tuloup

Results 2209 comments of Jeremy Tuloup

OK I think the basic functionality should be in place. All CI is now all passing ✅ Marking as ready for review to encourage folks to try it, for example...

Yes it would likely make sense to support this too. For large files the amount of data to transfer from the kernel can be quite big, but we can also...

> Yes it would likely make sense to support this too. For large files the amount of data to transfer from the kernel can be quite big, but we can...

Thanks @krassowski for the review! I think most suggestions have now been addressed, happy to create new issues to track follow-up improvements.

Adding to `4.1.0` for consideration, as this would be a useful feature to have.

bot please update playwright snapshots

Looks like the following error might be relevant: ![image](https://github.com/user-attachments/assets/0e61c29f-6773-4643-bda6-997169768215) Also need to check the effects of https://github.com/jupyterlab/jupyterlab/pull/16446 on Notebook.

> Looks like the following error might be relevant: > > ![image](https://private-user-images.githubusercontent.com/591645/348215290-0e61c29f-6773-4643-bda6-997169768215.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3ODA0MTQsIm5iZiI6MTcyMDc4MDExNCwicGF0aCI6Ii81OTE2NDUvMzQ4MjE1MjkwLTBlNjFjMjlmLTY3NzMtNDY0My1iZGE2LTk5NzE2OTc2ODIxNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMlQxMDI4MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMWM5ZGI1ZmMzOWE3MDU1MjUwMDllNDY2NDI1NDE1ODAwMThhNTc1ODc1OGNhNTYzNDQwMzc0N2IwNzE0YzU0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.j6C2_0HSYltqBaMXkS35FFi6eeBf7rEkggMzkj8oOHE) Just noticed an upstream change that might be relevant: https://github.com/jupyterlab/jupyterlab/pull/16523 cc @krassowski who may know more about this....

The error seems to be coming from here in JupyterLab: https://github.com/jupyterlab/jupyterlab/blob/7bae8e3238967a0a776028150b49a4903759bc90/packages/docmanager-extension/src/index.tsx#L337 ![image](https://github.com/user-attachments/assets/f477d9ed-6728-4fac-a96f-f4168565153c)

Thanks @krassowski for looking into this :+1: I guess we could just ignore this for now then. Spinning back a dev install for this branch, it looks like there is...