Jeremy Tuloup
Jeremy Tuloup
> Did you notice the missing button outside the tests? Usually not, so it might indeed just be an issue with the tests. There is some logic to wait for...
Re-opening to keep track of updating to a new JupyterLab version, and check if it fixes the flakiness.
From https://github.com/jupyter/notebook/pull/7378 (which should include https://github.com/jupyterlab/jupyterlab/pull/16335), it looks like this time it is the button to toggle the virtual scrollbar that is sometimes showing up: | Actual | Expected |...
Yes, thanks for looking into them! I'll re-open to keep track of it, which should be fixed after the next JupyterLab update.
Closing as likely fixed by https://github.com/jupyter/notebook/pull/7416. We can re-open if the failure still happens in the future. Thanks!
@stanwest regarding the issue for the tab being closed even after selecting "Cancel", we should probably fix this here and check the return value of the executed command: https://github.com/jupyter/notebook/blob/0a66f40c468ae2bf15faceba204288f614c96969/packages/notebook-extension/src/index.ts#L166-L167 @JasonWeill...
For reference `pyjs_code_runner` also seems to be doing the file copy here: https://github.com/emscripten-forge/pyjs-code-runner/blob/e4fb80073731fe9b0f773f29637a54e7765f6acd/pyjs_code_runner/run.py#L49-L66
It seems the current file is missing some `jp-search-*` variables: https://github.com/jupyterlab-contrib/jupyterlab-night/blob/main/style/variables.css For reference the JupyterLab dark theme defines them here: https://github.com/jupyterlab/jupyterlab/blob/2607c1093539850b5b618352dc94893a8b662e48/packages/theme-dark-extension/style/variables.css#L386-L396
For reference the JupyterLab Dark theme uses the following: ```css --jp-ui-font-family: system-ui, -apple-system, blinkmacsystemfont, 'Segoe UI', helvetica, arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; ``` https://github.com/jupyterlab/jupyterlab/blob/a3a0e3e7abf75e53810ed7ff8037c439cbb07697/packages/theme-dark-extension/style/variables.css#LL114C3-L116C23
Nice, thanks all for the comments and ideas for future implementations :+1: For now if someone is reading this thread and would like a basic workaround, the following code snippet...