Julien Tournay

Results 23 comments of Julien Tournay

I'm working on the `AvroType` part.

While I don't have a strong opinion on the design itself, it will introduce a pretty big breaking change for a benefit that seems, at least to me, unclear. Unless...

@nevillelyh @regadas @ClaireMcGinty Any opinion ?

This exactly. 100% agree with the `PDone` thing and indeed the only `Tap` I have actually seen used in the wild is `InMemoryTap`, for tests.

Related issues: - https://github.com/spotify/scio/issues/2171 - https://github.com/spotify/scio/issues/2642

From our recent experiments (porting a real production Scio 0.9 job to Flink), the biggest problem is different incompatible versions of Kryo being used by Scio and Flink. Downgrading Kryo...

@Igosuki is right, changing only Scio's deps works. We recently did some experimentation internally and "fixing" the deps conflicts (chill needs to be downgraded) is enough. You also need to...

Link to BEAM issue: https://issues.apache.org/jira/browse/BEAM-3122

@nevillelyh Can we close this ? The issue is upstream and has had no activity since Oct 2018 ?

Hi @martinbomio, I believe you're referring to [`runWithLocalOutput`](https://github.com/spotify/scio/blob/62213a1af371b6c0a23afc3f39d56c48838356f9/scio-test/src/main/scala/com/spotify/scio/testing/PipelineTestUtils.scala#L149) specifically as ` PipelineTestUtils` does use `forTest` in [`runWithContext`](https://github.com/spotify/scio/blob/62213a1af371b6c0a23afc3f39d56c48838356f9/scio-test/src/main/scala/com/spotify/scio/testing/PipelineTestUtils.scala#L39). For your use case wouldn't [`runWithData`](https://github.com/spotify/scio/blob/62213a1af371b6c0a23afc3f39d56c48838356f9/scio-test/src/main/scala/com/spotify/scio/testing/PipelineTestUtils.scala#L69-L71) be a better option for testing ?...