John "codefu" McDole
John "codefu" McDole
Does the `pairs` route incur allocation a new record for each map entry that will just immediately be destructured and thrown away?
> so the hardcoded values are no good Today they work great; but we're landing code in `flutter/flutter` to prep for the merge. After the merge, they'll be no good.
What I meant to say was the current hardcoded value wouldn't be good after the merge. If you choose between two, sure that'll work just fine.
Will this blow up the merge somehow? I.e. we'll get the wrong goldens on push?
These look suspicious. @jonahwilliams - it looks like these tests are having problems on Pixel 7 pros, but not mokeys https://flutter-dashboard.appspot.com/#/build?taskFilter=views_scroll_perf__timeline_summa&repo=flutter&branch=master ``` [2024-10-15 09:50:13.710057] [STDOUT] stdout: [ +995 ms] 00:00...
So we just searched for `- .ci/yaml` and added the engine and deps? That should trigger all the presubmits.
# Monorepo Migration Completed > **TL;DR: Please migrate your PR to flutter/flutter** The `flutter/engine` repository has been migrated to the `flutter/flutter` repository. This PR will no longer be landed here...
Pushing the fix in to the queue
It was not configurable imports, the compilation error I had while writing DDC tests while trying to use MemoryFilesystem was along the lines of mixins. Could interfaces be a proper...