John "codefu" McDole

Results 107 comments of John "codefu" McDole

For components that care about the camera (`TiledComponent`), how would they get access to the camera?

> how is the current `TiledComponent` using the old camera? With the mixin `with HasGameRef` where `T extends FlameGame` - so you can see that's immediately wrong. `onLoad` it grabs...

@spydon We use drawAtlas in Tiled via sprite batching: https://github.com/flame-engine/flame/blob/6fe517a0c20ac2508539f26766fc0f3c0f7a2ac2/packages/flame/lib/src/sprite_batch.dart#L366-L374

> We shouldn't ship this. Replacing all of the bounds checks with asserts means mismatched positions/colors could cause segfaults or other UB in profile/release builds. Would a compile time const...

Some of this work is going on here: https://github.com/flutter/flutter/issues/153059

`'\u001b[31m'` is the 3bit color for ansi and the package uses 8bit color. This library was written a very long time ago; but I'm happy to take PRs.

This package has used a global for a while. I wonder if I could store an Expando on a zone and retrieve it (since Zone.currrent[#color] cannot be set).

I *can* add a Expando on Zone.current, which makes things much nicer. I'll keep `color_disabled` for backwards compatibility though.

I know I'm late on responding to these. I like the idea of storing a stack of "complete state" such that: 1. down: bold + red + green background 2....