JT Thielen

Results 110 comments of JT Thielen

This kind of issue (repeated warnings) makes me question the current design of `parse_cf()`. Right now, using `parse_cf` with `varname` left as its default `None` is treated as "apply `parse_cf`...

:tada: :tada: :tada: Definitely +1 on exposing through the Dataset accessor. --- Given that this implementation is centered around parameter names, there are a few potentially problematic use cases that...

> I think first though, it’s best to step back first and ask: what problem are we trying to solve? Is it lessening the burden of correcting formatting lint? Yes,...

> Is there a way to run it in some kind of "diff" mode so we don't have to do a massive rewrite of files? If I'm interpreting this correctly...

These grid argument utils are almost certainly going to affected by the changes towards #893, so would it make sense to fix this along the way in (or as a...

Just an update from upstream: Pint v0.10 (to be released [in the next week or so](https://github.com/hgrecco/pint/issues/955#issuecomment-569270461)) will have preliminary support for wrapping Dask arrays. However, https://github.com/dask/dask/issues/4583 is holding up full...

Leaving a note here for future Dask compatibility work: the window smoother added in #1223 explicitly casts to ndarray, which prevents Dask compatibility for that smoother (and dependent smoothers like...

Overall, this looks good to me! After testing out various permutations of MetPy (before and after this change), pint-xarray, and cf-xarray, this indeed looks like the best approach we can...

> Does `pint.Quantity` _always_ refer to the current set registry? The top-level `pint.Quantity` as a class is in-effect a superclass of *any* registry's `Quantity` (even though using it as a...

> Up to this point, we've been able to limit "direct" use of `pint` to `metpy.units`, so I don't love that this is bleeding more uses of `import pint` across...