jtenner

Results 143 comments of jtenner

With the static function fix, everything seems to look nice. Thoughts? @dcodeIO

TODO: Implement `Buffer#compare`. TODO: Return 1, 0, or -1

Now the implementation contains a groked callback type verifier that does runtime checking of callback signatures. It requires a global map that contains a set of valid signatures for each...

@dcodeio conflicts aside, what's holding this request back? I just need to fix the builtin request. Right? Other than that, not sure how to make this better.

I think I'm going to implement a test function for utility purposes. ```ts function bufferFrom(values: i32[]): Buffer { let length = values.lengrh; let buffer = Buffer.allocUnsafe(length); for (let i =...

Do you think this can be merged? It looks good to me.

Six months in the making! Time to revive this pull request.

I can confirm this is an issue. Please fix.

Do you guys need some help identifying places where we should change the std lib?

also, I'm curious if this is faster? ```ts if (i32(x == 1) | i32(x == 2)) break; ```