Jeremy Cohen

Results 250 comments of Jeremy Cohen

I'm going to transfer this to `dbt-core`. I think the real blocker there is around understanding + consolidating the different options there. I also want to keep the follow-on work...

@dbeatty10 Amazing work pulling together all the threads from your research! I think there are two potential scopes for this work: 1. Do _just_ the work that's needed to remove...

I haven't had a chance to actually test any of this yet — just sharing the links here to share how I'm thinking about the narrower path I outlined above:...

> Is it so that users of dbt_utils >= 1.0.0 can update their references from `{{ dbt_utils.current_timestamp() }}` to `{{ current_timestamp_backcompat() }}` (assuming the end user has dbt Core >=...

I think what we want here is just good old `args_to_dict`: https://github.com/dbt-labs/dbt-core/blob/94a7cfa58df3df5d3b07b619c0510fead9195700/core/dbt/utils.py#L630-L636 That's what we use in the [`MainReportArgs` event](https://github.com/dbt-labs/dbt-core/blob/94a7cfa58df3df5d3b07b619c0510fead9195700/core/dbt/main.py#L230), and it's also what we use [when writing `run_results.json`](https://github.com/dbt-labs/dbt-core/blob/94a7cfa58df3df5d3b07b619c0510fead9195700/core/dbt/task/runnable.py#L585). It...

@lostmygithubaccount Agree - we should still do this! In `dbt-core` and our adapter repos, too

> Requiring adapter maintainers to take direct action to maintain the reliability of the structured logging interface is something we'd like to avoid Agree in principle. I'm on the fence...

I've come around on this, given the way that we've implemented Python on some adapters. The `statement` macro has become the "gateway" for both SQL + Python code, and it...

To provide a concrete/motivating example, if you include the following code in a model: ```sql -- models/my_model.sql {% set mylist = None %} {% for item in mylist %} select...

@callum-mcdata Thanks for the detailed comment! I just opened it as a new issue, for a spike/investigation: https://github.com/dbt-labs/dbt-core/issues/5637 Let's keep using this ticket for the narrowly scoped fix described above:...