Jeremy Cohen

Results 250 comments of Jeremy Cohen

I think this would be a _great_ use case for a new logging level and/or flag akin to `--log-cache-events`. Most users running locally will not want the full information here....

One thing I quickly caught: > dbt cloud: v1.0 > I have tried search for bug reports but haven't found much in the area except this issue https://github.com/dbt-labs/dbt-core/issues/4347 which I...

Leaving them in `nodes` with `enabled: False` makes intuitive sense, if we're not doing the right things in the `disabled` dict. It would be a significant (likely breaking) change for...

@gshank Would you be able to take a look at the reproduction case @jeremyyeo laid out, when you get a chance? Since more folks have upgraded to v0.21+, we should...

As part of this effort, I'd like to create distinct classes for each `warn_or_error` call site as well. Currently, it just passes everything into the generic method `raise_compiler_error` or the...

@lostmygithubaccount Thanks for including the full reproduction case! I agree, this is undocumented behavior at the extension / intersection of the selector inheritance functionality recently added (by @danieldiamond!) in https://github.com/dbt-labs/dbt-core/pull/4827....

> However, this isn't the correct test file format. guilty! > I have the appetite to fix up the file formatting and will push the changes up to your branch....

One other thing that comes quickly to mind: How to differentiate between whether the `field` (column) name ought to be quoted, versus the `value`? We could have sensible per-database defaults...

Sounds a lot like the changes we made to support `target-path` and `log-path` (https://github.com/dbt-labs/dbt-core/pull/5402). For consistency with those and other "global"/runtime configs, the precedence order would want to be: 1....