jsygit

DirectIO WAL Write does not honor DBOptions.use_fsync

2

In my test using direct io for WAL write (with ext4 in the kernel), I noticed direct io WAL writes do not do metadata sync even when I have DBOptions.use_fsync...

WritableFileWriter::WriteDirect's buf_.RefitTail() causes redundant disk write when an immediate Flush() is invoked right after.

2

In Log Writer's WritableFileWriter::WriteDirect(), an unaligned write using would result in rounding up the buffer to an aligned size. It also leaves a "leftover_tail" bytes with the intention to be...