jswxstw

@alexec Do you know why plugins in controller namespace are needed?

> I’m not sure a user plugin should try and use a controller service account, so this seems to be a bug. Controller plugins are loaded by default, so controller...

> This seems odd to me too. Agents are part of the workflow, not part of the control-plane, so should run using the service account of the workflow. @alexec I...

> how can the expression cover a pod that did not start? Why not use `lastRetry.message ` directly, rather than extracting exitCode from it. @tooptoop4

> LGTM. > > Looks like the test failures are the common ones which have been happening recently. Related to: https://github.com/argoproj/argo-workflows/pull/12730#issuecomment-1975644264

> To trigger a re-run I updated the branch via the button on the GH UI, selected rebase instead of merge, annnd it [broke DCO](https://github.com/argoproj/argo-workflows/pull/12732/checks?check_run_id=24581603842) I fixed it, but there...

> Ah I see, because it doesn't support the `kill` command etc (which is pretty hacky as-is). Could you leave a TODO comment above this line then, e.g. `// TODO:...

> How is TTL related there? Since it's only deadline related Sorry, I made a mistake and I actually meant the workflow's deadline. I actually want to say that it...

@agilgur5 Can this PR be merged?

> This was the only thing I was waiting for. Has actually been on my to-do list to add this myself since I have that permission these days I updated...