Jonathan Supnik (Demi)

Results 5 comments of Jonathan Supnik (Demi)

Unions generate code that is not C#7 compliant

I've created a PR to address this issue: https://github.com/Cysharp/MemoryPack/pull/305 but don't know how to add reviewers.

Fix issue 304: Use of C# 9 feature in library targeted at C# 7.

The documentation on the readme page guarantees C#7 support. For our own uses, we were using C# 8, which also didn't support the feature. Once I fixed this one particular...

Fix issue 304: Use of C# 9 feature in library targeted at C# 7.

Ah, that's confusion on my part. I hadn't realized the versioning system for C# was so complicated. Regardless, I think my fix improves compatibility with older C# versions, and doesn't...

Fix issue 304: Use of C# 9 feature in library targeted at C# 7.

Hello. I was wondering if you were planning to take this fix as part of the main trunk for MemoryPack. If not, I'll look into updating our build process to...

Fix issue 304: Use of C# 9 feature in library targeted at C# 7.

The C# 7 part was me misreading the requirements. I can retitle if desired. The actual C# version is C# 8.