James Sumners
James Sumners
Basically your quote.
Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into...
I do not wish to complicate the core repo contribution workflow. The website build should be able to accommodate the normal PR process.
No objections here.
> Also, with the rise of ESM-Modules, imports mostly shift from something like `const Fastify = require('fastify')` to `import Fastify from 'fastify'`, which makes things, such as `const app =...
I think `app` implies Express ways of thinking. But I don't have any strong preference as long as the documentation makes sense.
Feedback is of course welcome, but you'll find that it gets incorporated quicker (if at all) if you submit a PR that actually implements your ideas.
Please read https://www.fastify.io/docs/latest/Reference/Encapsulation/
I think this RFC is too tightly coupled to application implementations to be implemented generically.
Do not make it an `instanceof` check. Add a `Symbol.toStringTag` and check `Object.prototype.toString.call`.