website-metalsmith icon indicating copy to clipboard operation
website-metalsmith copied to clipboard

Switch hosting provider

Open luisorbaiceta opened this issue 3 years ago • 19 comments

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

There is already an open issue that suggest the change to Netlify #84, But I think any provider that has deployment previews and redirections should be fine.

Any good personal experience and recommendation with a hosting provider that meets the motivation of the issue will be very valuable!

Motivation

PR previews (#153 ) Redirections and rewrites (#312 )

luisorbaiceta avatar Dec 20 '21 09:12 luisorbaiceta

@sinchang, in your experience with Netlify, do you think it could solve #312?

luisorbaiceta avatar Dec 20 '21 09:12 luisorbaiceta

I think we can switch to Netlify given (https://www.netlify.com/legal/open-source-policy) or Vercel (https://vercel.com/support/articles/can-vercel-sponsor-my-open-source-project).

Whatever you chose - I have contacts on both providers.

mcollina avatar Dec 20 '21 11:12 mcollina

Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into main.

jsumners avatar Dec 20 '21 13:12 jsumners

@luisorbaiceta if you include a badge https://www.netlify.com/press/#badges in the footer, I can request an OSS account from Netlify.

mcollina avatar Dec 20 '21 13:12 mcollina

Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into main.

I'm afraid this is a consequence of the current build process and has nothing to do with the provider. A good solution would be to always work on the same branch the docs changes (wip/docs) and targeting that specific branch in the build process (like we do with master branch). We can leave that part hidden for the final user and only make it available by route access

luisorbaiceta avatar Dec 20 '21 14:12 luisorbaiceta

I do not wish to complicate the core repo contribution workflow. The website build should be able to accommodate the normal PR process.

jsumners avatar Dec 20 '21 14:12 jsumners

@luisorbaiceta it should be possible by triggering a rebuild using the API.

mcollina avatar Dec 20 '21 14:12 mcollina

If changes have not been merged to master, there is no way to preview them without knowing the name of the branch those changes have been made in beforehand. See here

luisorbaiceta avatar Dec 20 '21 14:12 luisorbaiceta

@luisorbaiceta if you include a badge https://www.netlify.com/press/#badges in the footer, I can request an OSS account from Netlify.

Should we choose Netlify then?

luisorbaiceta avatar Dec 20 '21 14:12 luisorbaiceta

I would go ahead with Netlify unless somebody has a strong preference for something else. I don't know what would entail to pick Netlify vs something else (or roll our own). I'm just working to create a sponsored account for Fastify.

Do anyone have an objection in picking Netlify?

mcollina avatar Dec 20 '21 17:12 mcollina

Great! Let me know when credentials are ready so I can start a PR to work on the new workflow

luisorbaiceta avatar Dec 20 '21 17:12 luisorbaiceta

I'd need the badge to be there to do that.

mcollina avatar Dec 20 '21 17:12 mcollina

Should we wait a reasonable time then to see if anyone has any objections with Netlify? If not, I have time to add it now

luisorbaiceta avatar Dec 20 '21 18:12 luisorbaiceta

Open a PR, let's wait a day or two to land it.

mcollina avatar Dec 20 '21 18:12 mcollina

No objections here.

jsumners avatar Dec 20 '21 18:12 jsumners

I have requested an OSS account from Netlify

mcollina avatar Dec 27 '21 11:12 mcollina

@luisorbaiceta I have invited you to Netlify

mcollina avatar Dec 28 '21 08:12 mcollina

Great! We can now trigger deploys by connecting the account to the repo, or by setting up a workflow from github actions. I'm fine with both approaches

luisorbaiceta avatar Dec 28 '21 09:12 luisorbaiceta

As you prefer, you should have enough permissions for both - in case let me know.

mcollina avatar Dec 28 '21 09:12 mcollina