Jonathan Striebel

Results 113 comments of Jonathan Striebel

@mahmoud Friendly ping :-) What do you think about adding those changes?

I just found a blockly based editor for json logic: https://katirasole.github.io/JSONLogic-Editor/ https://github.com/katirasole/JSONLogic-Editor Shoutout to @katirasole, thanks a ton!

The Linux tests fail due to some s3 tests, and the Windows test timeout in the s3 fixture setup, which also fail on different branches and seem to be unrelated...

@joshmoore & @grlee77 Would one of you have time to review my changes here? Asking since you authored the initial v3 additions here. From my side this PR is ready...

> I have some minor suggestions, but this looks pretty good already. Thank you so much for the review, @grlee77! I applied your feedback in the recent commits. > I...

> allowing partial byte ranges to pass through to the storage layer and transformers seem completely orthogonal to me. Yes, it is to some extend. I can also have them...

> > I also thought about just having an empty list as the default, but lists as default arguments are somewhat deprecated due to their mutability. > > And a...

I opened the follow-up issue #1106, which is about implementing optimized partial read/write methods for specific stores, and using them for the partial decode routines.

@grlee77 @joshmoore Thank you very much for your reviews! I incorporated your feedback where I marked the comments as resolved, the other's are still open conversations. Could you give this...

@grlee77 @joshmoore I've incorporated some more changes that were useful for the sharding PR #1111. I added them here to keep the PRs clean. Could you have a look at...