John Starks

Results 9 comments of John Starks

We can increase the default there, but we should also fix Docker to support —ulimit and —default-ulimit when LCOW is supported. @jhowardmsft

Thanks for the contribution! I think it might be cleaner to require a special flag for this case rather than auto detect, since the user surely knows which case they’re...

I think we can get this merged, I'd just like to see some minor cleanup first.

I think `select!` is irreparably broken. We have been migrating our code off of `select!` and onto the trait-based mechanisms in .

If we stabilize inherit and skip stabilizing dfl, then people who want dfl can explicitly make the call in main themselves. And then you can remove the dfl option altogether...

In our code, we often parse structures with fixed headers and then some dynamic portion, from a potentially unaligned buffer. To support this, it has been nice to have both...

The tone was intentional. They could have chosen any number of alternatives. They made the choice to break users.

This looks cool. Is the thinking that specifying the backing would become optional, or would it be prohibited? I'd prefer optional, where `bitfield(u32)` continues to enforce an alignment of 4...

(Really I think I'd probably avoid the bare `bitfield` attribute altogether, since if I'm using bitfields, I almost always want to know, specify, and enforce the underlying backing type. Otherwise...