Jochen Staerk comments

Results 326 comments of


                                            Jochen Staerk

BUG: Validation error when using direct debit

raised their issue 207

BUG: Validation error when using direct debit

They checked and they could not find that it was allowed in EN16931-3, this becomes a wontfix and I've asked the Kosit to review [their validation](https://github.com/itplr-kosit/validator-configuration-xrechnung/issues/124).

Improve GitHub Actions

@svanteschubert authored the original github action which is supposed to test mustang, can someone please fix it?

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

Hi, would you maybe have a short source code snippet available which I could use to validate the issue and make a testcase out of it? thanks Jochen

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

> Hi, what is the preferred way using charges/allowance? I mean, which information needs to be set. Thanks ``` BigDecimal itemVATPercent=new BigDecimal("19"); BigDecimal theAmount=new BigDecimal("10"); item.addCharge(new Charge(theamount).setTaxPercent(itemVATPercent)); ``` puts a...

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

Thanks, I'll have a look tonight

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

Unfortunately I cant reproduce the XML from your JSON (wrong date format, and then other problems), and the source code is not complete but when I try it myself with...

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

I may try if you just tell me which java source code precisely creates an invalid xml?

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

> [@jstaerk](https://github.com/jstaerk) i tried to push an initial idea how to calculate the percentages on invoice level but it seems like I have no permission to push a branch :-)...

Having two items with different VATs and adding a charge/allowance on document level will generate a XML with incorrect values

@FrankHossfeld ``` 1x Product1 100 € with tax 7% 1x Product2 100 € with tax 19% + Allowance on invoice level with e.g. 19% tax base. ``` Let's say we...