Jurriaan H. Spaaks
Jurriaan H. Spaaks
https://github.com/asreview/asreview/blob/9b776ba928e1a2279867a0266d5c244afbe937da/asreview/settings.py#L81-L101 Unused && marked deprecated: 1. `abstract_only` 1. `mode` 1. `n_papers` 1. `data_name` Additionally, these 2 are unused: 1. `data_fp` 1. `n_queries` The arguments are not used in the code....
1. plot "Progress" has unequal intervals on the yaxis (I have y=0, 3, 7, 10) 1. plot "Recall" has unequal intervals on the yaxis (I have y=0, 2, 5, 7,...
https://github.com/asreview/asreview/blob/9b776ba928e1a2279867a0266d5c244afbe937da/asreview/models/query/base.py defines the abstract base class for query strategies, but also `ProbaQueryStrategy`? Maybe the latter should be moved to its own file.
`definitions`, or `$defs` in draft 2019-09, are just meant for internal use. Maybe we should not have them as part of the schema guide. Removing them would help have a...
- consider reordering the sections to Changed, Added, Fixed such that they correspond with semver - check that items are in the right section considering semver
**Related issues** Refs: - #38 - #268 **Describe the changes made in this pull request** This PR changes the schema such that it can accommodate authors with multiple affiliations. Under...
some of the info there is outdated, e.g. 
`license-url` could be a type of `license` as per: ```json "license": { "oneOf": [ { "$ref": "#/$defs/license-enum" }, { "$ref": "#/$defs/url" }, { "items": { "oneOf": [ { "$ref": "#/$defs/license-enum"...
Should `contact` really be named `contacts`? Since its type is same as `authors`? Looks like it already tripped us up when looking at the index :) 
CFF schema version 1.2.0 has keys 1. `repository` 2. `repository-artifact` 3. `repository-code` 4. `url` How to apply options 1-3 is rather confusing; option 4 is clear but its downsides are...