Jurriaan H. Spaaks
Jurriaan H. Spaaks
either by casting at the end, or by using a different type for its input arguments
The current implementation of ``calc_scores.calculate`` is deliberately naive while we are sorting out the refactored skeleton of ``matchms``: https://github.com/matchms/matchms/blob/672cbbc17169e63531c864518e29e34a6b0072d4/matchms/Scores.py#L18-L22 However, once we sort that out, we should starting thinking about...
I think we can do with just 1. https://github.com/matchms/matchms/blob/106b4cbc058b924aa9170f3f8cb32bcc49054011/.github/workflows/conda_build.yml#L47-L53
https://github.com/passcod/citeworks referenced here https://github.com/citation-file-format/citation-file-format/issues/28#issuecomment-1214148573
code state: [9b776ba](https://github.com/asreview/asreview/tree/9b776ba928e1a2279867a0266d5c244afbe937da) **model / strategy / classifier** In `asreview/settings.py:ASReviewSettings` the member names are inconsistent: `.model` (a classifier strategy), `.query_strategy`, `.balance_strategy`, and `.feature_extraction` are all strategies, their naming scheme should...
`/reviews//results.sql`: consider using the `*.db` extension instead of `*.sql`, such that tools like "DB Browser for SQLite" are able to show the results files by default. This stackoverflow has a...
The mixed query strategies `MaxRandomQuery`, `MaxUncertaintyQuery` and `MixedQuery` use a confusingly named parameter `mix_ratio` whose name suggests that the ratio is between the two strategies, which it is not. Relevant...
In `./.github/workflows/pythonpackage.yml`, we build the distributable with `python setup.py sdist bdist_wheel` but I don't think we ever test if that works and/or actually contains what we need. We could set...
```python from asreview.settings import ASReviewSettings as Settings from asreview.models.balance import SimpleBalance from asreview.models.classifiers import NaiveBayesClassifier from asreview.models.feature_extraction import Tfidf from asreview.models.query import MaxQuery def get_extractor(): params = { "ngram_max": 2...