Johannes Meixner
Johannes Meixner
What I will do here for ReaR 3.0 is that I will check the specific cases in https://github.com/rear/rear/pull/3203#issuecomment-2063439858 where ReaR seems to source "third party" files i.e. files that seem...
Progress report: Via https://github.com/rear/rear/issues/3285 I checked all cases where ReaR calls 'source' whether or not it my source third party files. I found those cases where it was not clear...
Regarding those cases where '.' is used to source a file: Perhaps it is not as hopeless as I feared because ``` # find usr/sbin/rear usr/share/rear/ -type f \ |...
What is left for me to do here for ReaR 3.0 is that I will have to check the specific cases in https://github.com/rear/rear/issues/3260#issuecomment-2248252572 where ReaR seems to source "third party"...
@lzaoral in your https://github.com/rear/rear/pull/3171#issuecomment-2012100925 you wrote ``` the final '|| return 1' is necessary because bash returns 127 on unbound variables ``` Why does it matter what non-zero return code...
@lzaoral thank you for your prompt reply. I dropped it via https://github.com/rear/rear/pull/3203/commits/ef14f5f382147d67af76210a8b0d8f957df0f037 but I did not test it with the dropped final '|| return 1'
I prefer names that tell what a function actually is about. `get_var_from_file` is too unspecific. Regarding `get_shell_file_config_variable`: I wonder why it is limited to _config_ variables? I.e. why not only...
Via https://github.com/rear/rear/pull/3203/commits/12c3ccb8f00affa7d3a36e915602abee12328fc5 I renamed get_var_from_file into get_shell_file_config_variable to tell what that function actually is about plus adapted and enhanced/fixed comments.
I think I better withdraw my pull request here and leave it to you and @pcahyna and @lzaoral how to get the value of a variable out of a file...
@schlomo at least for now I would like in this particular case to relax from this particular Relax-and-Recover issue. I spent already way too many hours on this issue which...