Judith Massa

Results 43 comments of Judith Massa

Is this ready to review again, @kordano?

A solution should also consider imports and exports

Issue #13 also deals with schema changes

Might have already a solution in PR #503 and should not be worked on until #503 is merged

I also think it should be ensured on `-connect`. As far as I can see, in all other cases, the `max-eid` should already be present. @kordano Did the underlying problem...

I'd say it could get a bit too complex for something integrated into datahike itself. What do you think, @kordano?

What do you mean? Do you want to somehow include it in the `-seq` function or count everything stepping through the sequence just once?

Sure, you can write it like that. I don't think it has performance benefits either though. I would expect that it will still step through the sequence twice; once for...

The db namespace will be refactored with #555 Concerning the test folder, I can see, that - the second test subfolder can be removed, i.e. `test->datahike->test->api_test.cljc` would become ` test->datahike->api_test.cljc`...

I think, we should talk about some of the unused functions. I remember that for some of them I do not know, why they are never used.