Jon Skeet
Jon Skeet
Discussions: - Using `T?` when `T` is unconstrained should be forbidden in C# 8. (For C# 9 we'll need to explain some oddities.) - `where T : class` should be...
We observe that Roslyn allows both of these: ```csharp public class Foo where T : notnull, Stream public class Foo where T : notnull, Stream? ``` This PR prohibits both....
Yes, this definitely seems sensible to me.
Yup, that seems reasonable to me. We should get approval from other folks before *merging* any change though.
(Sorry that there's so much to review. Do take your time. ;)
This is the .NET repository - I'll transfer your issue to the Java auth repo.
Indeed. Nor, I would suggest, this: `const string a = nameof(b), b = nameof(a);` I suspect we should carve out an exception of just "`nameof` can take the name of...
@googleberg Do other languages allow access to the unknown fields? I certainly don't want to just casually make things public - this would be a big decision, to be considered...
Oh, and even just "Expose UnknownFields on IMessage" would be a breaking change - that's definitely not something I'd want to do. If we do this at all, I think...
Just checked, and it's public in Java too. (That's my normal point of reference as the closest language to C#.) Okay, I'll see when I can find some time to...