Jon Skeet

Results 749 comments of Jon Skeet

Okay, it's now "flaky" rather than "permanently broken". I believe it's the integration tests that are failing. Still needs fixing...

I don't know anything about integrating Swagger and ASP.NET Core, but if Swagger is expecting to serialize and deserialize the events itself, that needs to be changed - event formatters...

Unfortunately this is beyond my knowledge of Swagger. I would say that even if this had worked, it would still be non-ideal, in terms of not talking about the CloudEvent-specific...

This hasn't been done for 2.0; I still have the Protobuf event formatter to finish though, so when that's done it will give us more data.

I will look at this on Monday when I'm back from holiday. It's relatively awkward to make CloudeventAttribute plenty equality due to constraints - unless we decided to make that...

We could add extension methods for that easily without a new collection type. Anyway, will look more carefully on Monday.

Looking at this again, while introducing some equality comparers might still be useful, I think for your current use case you could just use: ```csharp var attributes = ce.GetPopulatedAttributes().ToDictionary(pair =>...

Okay. I'll keep going with the `IEqualityComparer` PR then. That would allow something like: ```csharp Dictionary dict = new(ce.GetPopulatedAttributes(), CloudEventAttribute.NameComparer); ```

@n3wscott: Note that that proto is slightly out of date - it doesn't include batch support (and doesn't have a csharp_namespace option, although that shouldn't affect go). The most up-to-date...

This will be post-2.0.