John Sirois comments

Results 436 comments of


                                            John Sirois

Why does creating a virtualenv for torch take about 7 seconds?

Ok, #2315 addresses "Building 0 artifacts and installing 22: 3142.4ms" and takes it to ~10ms. There is still "Installing 22 wheels in venv at ./tenv: 3585.3ms" to improve. The issue...

Implement support for incremental lock resolves.

On this 1st bullet point, a typical resolve process with backtracks etc, might visit, say 10k nodes and the final solution set have 100 nodes. With Pip supporting PEP 658...

The `pex` import hook does not handle registering top level PEP-420 packages

The vendor importer is installed here: https://github.com/pantsbuild/pex/blob/98c2640602ed3d2820f8e4f66dadc6c59df120dd/pex/pex_bootstrapper.py#L577-L587 And that leads to the issue via: https://github.com/pantsbuild/pex/blob/98c2640602ed3d2820f8e4f66dadc6c59df120dd/pex/third_party/__init__.py#L262-L279 https://github.com/pantsbuild/pex/blob/98c2640602ed3d2820f8e4f66dadc6c59df120dd/pex/third_party/__init__.py#L167-L175 The two module iterator implementations both assume packages have dunder-inits in them: https://github.com/pantsbuild/pex/blob/98c2640602ed3d2820f8e4f66dadc6c59df120dd/pex/third_party/__init__.py#L82-L93 https://github.com/pantsbuild/pex/blob/98c2640602ed3d2820f8e4f66dadc6c59df120dd/pex/third_party/__init__.py#L106-L129

Plumb ignore_errors to `LockedResolve.resolve`

I'm not sure what implementing this requires. I'm pretty sure the legacy resolver is depth-first such that the 1st traversed requirement for a particular distribution wins and sets the result...

Building a PEX for multiple platforms doesn't affect `sys.platform` in `extras_require`

I just noticed this issue. AFAICT it has since been ~solved on all points: + Environment markers are now fully supported, even for `--platform` (#1367 in 2021) and the newer...

Building a PEX for multiple platforms doesn't affect `sys.platform` in `extras_require`

@AlexTereshenkov it would be really useful if you could provide full info (the lock file in question). As it stands it's not clear to me your report is totally germane...

Building a PEX for multiple platforms doesn't affect `sys.platform` in `extras_require`

@AlexTereshenkov your primary use case is tortured via Pants as far as I can tell. IIUC you want a PEX of only your 1st party code (since all 3rdparty code...

Allow system_site_packages=True in Virtualenv.create()

Did you know you can do this?: ``` PEX_TOOLS=1 ./my.pex venv here/ --help ``` Or use the `pex-tools` console script available when you install the `pex` tool: ``` pex-tools ./my.pex...

Allow system_site_packages=True in Virtualenv.create()

Aha, right. So, if a `pex-tools venv --system-site-packages` option were added, would that work for you then? If so I'll mark this as a feature request and if you want...

Add CI for Windows

@chrisjbremner you might want to kill all the non-Windows shards in .travis.yml to speed up iteration. We share a queue with pantsbuild/pants which can sometimes slow things down a good...