Results 423 comments of John Sirois

> By "kill" do you mean temporarily delete them/comment them out? Yes.

I disagree with Eric on this one and would prefer a real green all in one here with the .travis.yml and the code fix.

@chrisjbremner one thing you might try is not fighting so hard against the motivating example tox.ini you found. That tox.ini sets PATH: https://github.com/mapaction/mapactionpy_controller_dependencies/blob/6b3fcce09d29c20d6ec51040fd0449f0ab3d984a/.travis.yml#L12 Perhaps do things _just_ like they do.

If you do pick it up @g-cassie - which would be great - note that Pex has since converted from Travis-CI to Github Actions. They still have windows support so...

Pex has never supported Windows, so the fact it ever worked in an elevated session was by luck! Apologies for the lack of attention to this issue. The active developers...

> Ah, wonderful, I've just found the docs for pyo3 https://docs.rs/pyo3/latest/pyo3/. Great. Yeah @cosmicexplorer that's exactly what I meant. I've been away climbing here and haven't taken a look yet,...

> I think this change produces a really drastic and noticeable performance improvement for an extremely common use case (especially the use of pex in prototyping) Why not use `--layout...

> I used the term "prototyping" very loosely. I was merely emphasizing how often --layout zipapp is employed for the user's convenience. Our docs at https://pex.readthedocs.io/en/v2.1.140/buildingpex.html#saving-pex-files don't mention the other...

I wanted to note I won't be back online until ~Friday August 4th.

I'm reviewing presently, but as to: > 1. source files now come before .bootstrap/ in the output of unzip -l for --layout zipapp: This is not good for 2 reasons:...