Julia Signell
Julia Signell
Looks like only flaky tests left!
> Thanks Julia! I powered through `test_concat` and `test_merge`. I'll need another 2 hours to do `test_backends` and `test_combine`. But hopefully we can get this in for the next release....
Hahah yeah still interested! I just didn't know what to do to make it palatable :) so I'm stoked to have your review!
Ok! I pushed the changes I was talking about and merged in main. I think the flaky tests are just being flaky 🤷🏻
> > I just didn't know what to do to make it palatable :) > > Hehe, it's just a hard complex change. I had to check it out and...
I just did an experiment where I flipped the switch on `use_new_combine_kwarg_defaults` to make sure that tests act as expected. These are the results: ``` ========================================================================== short test summary info...
Yeah this isn't terribly surprising. The pd nullable types are not super well supported. I think you can get through your first issue with this change: ```diff diff --git a/dask/dataframe/core.py...
Do you think this is the same issue? ```python import geopandas import pystac import stac_geoparquet URL = "https://www.planet.com/data/stac/disasters/hurricane-harvey/catalog.json" catalog = pystac.read_file(URL) dicts = [item.to_dict() for item in catalog.get_items(recursive=True)] df =...
It looks like maybe the thing to do is to convert to string before storing arbitrary json blobs? ```python import json import geopandas import pystac import stac_geoparquet URL = "https://www.planet.com/data/stac/disasters/hurricane-harvey/catalog.json"...
Thanks for writing this up! I am able to reproduce. I think it has to do with the assigment to a new column that comes after the groupby. Here is...