Jegor Sidorenko

/cmd queue -c bench-bot $ pallet dev pallet_nfts

> I think this has a lots of potential. The only issue I have with the swap design is; how does a user know if he has to call `create_swap`...

@ruseinov @ggwpez @muharem I've added a new price_direction param and addressed all the comments you put. Could you review this PR again pls?

/cmd queue -c bench-bot $ pallet dev pallet_nfts

> Looks good. > > I think the point about storage deposit and maximum duration still stands, since otherwise the user can just litter the chain with swaps. The storage...

bot merge

What if we create a separate struct like AssetOrNative that will keep inside the information about the assetId or currency and the amount? I would be glad to use it...

Yeah, if you check the commits history, initially I put an `Option` param into the `item_buy`. Then I realised there could be more methods those would want to get the...

> But then there's no reference to point out which NFT it's a tip for. I think this is critical for a lot of external systems to know the NFT's...

I've converted tuple into struct as per Oliver suggestion