Ioannis Sfakianakis
Ioannis Sfakianakis
> @jsfakian instead of cherry-picking a commit for kernel you should run tools/update_kernel_kommits.py to grab full history of changes. I did that, thx.
Dear all, This is a huge PR; unfortunately, I could not do it in parts. Please commend me for any questions or concerns.
> Given the separate work on configuring the network parameters, do we really want a subset or duplication in here? The key thing we are missing in the installer is...
> > Dear all, This is a huge PR; unfortunately, I could not do it in parts. Please commend me for any questions or concerns. > > Can't you do...
@eriknordmark, @deitch, @rene, @rucoder, I think I covered most (if not all) of the comments. Should we merge, or do we need more changes?
> I added some comments, so I will sum up here. > > * README: thank you for updating with how it works. It needs a bit more, primarily anything...
> @jsfakian, is this PR still in progress? If so, should we mark it as WIP and convert it to a draft? Hey @OhmSpectator, this PR is still in progress....
> #4248 is in. You should be able to rebase on that one. But... you should not have to change _anything_ except what is in `pkg/installer`. Everything outside of there...
> This passed the eden tests. Are there outstanding review comments or is this ready to go? It is ready to go.
> Almost everything is ready to go. I have one unanswered question: > > > Final question is vendor.tar.gz. Is that to work around the fact that we have network:...