Joe Spencer comments

Results 181 comments of


                                            Joe Spencer

Allow ability to disable "servers" property from automatically forwarding all requests

i'd be open to PRs for this.

Initialize slow with large specs

dang! 500 paths is a lot! are the external references downloaded when your server starts up? if so, i'd bet that's where most of your slowness is happening.

Initialize slow with large specs

well, with 500 paths, i can only imagine how many operations you have. if you were to `require` all those files without calling `.initialize`, how long does it take?

Initialize slow with large specs

right, but during `.initialize`, it's going to call `require` for each of the paths right? what's the output of this? ``` find ./paths-dir -type f | wc -l ```

Initialize slow with large specs

depending on how many require calls the framework has to make, it may make sense to use `args.operations`.

Initialize slow with large specs

oh, well that changes everything lol using `console`, can you log before and after times before and after the initialize call?

Initialize slow with large specs

wow. well, that's definitely slow. it would be nice if we had a way to optionally turn on profiling logs

Initialize slow with large specs

i can offer theories, but it would be amazing if you could profile this locally: https://nodejs.org/en/docs/guides/simple-profiling/ i assume it's as slow or slower on your local machine?

Initialize slow with large specs

https://github.com/kogosoftwarellc/open-api/blob/master/packages/openapi-framework/src/util.ts#L150

Initialize slow with large specs

That copy function is actually called a lot: https://github.com/kogosoftwarellc/open-api/blob/master/packages/openapi-framework/index.ts The point was to guarantee a deep copy in case the rest of the framework alerted the original doc in some...