Jan Schädlich
Jan Schädlich
Hi @tugrul I made the `Validator` final on purpose. If I open it for extension, it would be much harder to change any internals in future releases. I can imagine...
Hi @OskarStark Implementation is done. But I have no idea why tests are failing on PHP 7.4 🤔
@OskarStark I rebased the branch. Tests are still failing on PHP 8.0 but this seems to be unrelated with my changes.
Needs rebase after https://github.com/symfony/symfony/pull/40842 was merged
@OskarStark I am about to split this PR. 1. Adding the missing TransportFactories to the FrameworkBundle: https://github.com/symfony/symfony/pull/40843 ✅ 2. I would like to add basic tests for the Framework integration...
Rebased and ready for another review :-)
@OskarStark Rebase done.
I rebased again. Looks good to me now.
This fix wasn't released until now. But here you go: https://github.com/jschaedl/iban-validation/releases/tag/v1.8.3
Closing here now. Thanks for reporting this.