Jyri Sarha
Jyri Sarha
@singalsu , the PR is here. Please let me know when we are ready to mark this "Ready for review".
@perexg , I think this should be ready for merging.
Now the PR contains also the code force the capture hw mute indicator to muted state, when DSP is powered down.
> @jsarha, what I would do is: rename the `ipc4-telemetry.c` to `ipc4-debugfs.c` or something generic and use this to export the raw slots on the needed base. You can have...
@ujfalusi @kv2019i , according to my tests the exception debugfs file works just as well after this change as it did before. That is, neither version works. I have no...
> @jsarha @ujfalusi ping - can we unblock ? This is not as important anymore as before, as the latest debug_stream.py is able to access its debug-window-slot directly using cavstool.py...
Rephrased the first commit message a bit and resurrected ipc4-telemetry.h in the last commit (and updated the message accordingly), which is currently actually used. The code still works with debug_stream.py.
@lgirdwood , @lyakh , the phantom commit is now removed, and there was no complaints about the other commits, so this should be good now? Thanks @ujfalusi !
@lyakh is this Ok now? @bardliao , @lgirdwood only appled three last suggestions from Guennadi (Copyright 2024-2025), free in only one place sof_debug_slot_debugfs_entry_read(), and rename sof_ipc4_create_debug_slot_debugfs_node() to sof_ipc4_create_debug_slot_ro_debugfs_node() . Could...
@lgirdwood should we still get this merged? @ujfalusi should I rebase, the PR getting old, again?