Jyri Sarha
Jyri Sarha
The first patch was updated and now this appears to work Ok.
Addressed the last comment, but there is conflicts now... rebasing.
Yesterdays version now pushed again with @plbossart 's suggestions for descriptions and after a rather painful rebase. I am currently looking at how to add codec side format constraints to...
Updated to work with this latest sof topology pr: https://github.com/thesofproject/sof/pull/6524
> Mostly editorial review. The only open I have is how the codec DAI limitation is handled, if at all? Since this feature is enabled through topology, would it be...
On more round of applied review fixes, while waiting for https://github.com/thesofproject/linux/pull/3972 to get ready. The sig_bits are still not copied from codec side, but that should not make big functional...
Latest changes: Make sure the tplg is using use_chain_dma correctly. I keep the loop in sof_ipc4_trigger_pipelines() and then add a check in sof_ipc4_chain_dma_trigger() that all elements in list have the...
Only the 0xffffffff => SOF_IPC4_INVALID_NODE_ID change.
Addressed @plbossart 's comments and changed -ENOTSUPP to -ENODEV due to checkpatch error: WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #313: FILE: sound/soc/sof/ipc4-topology.c:528: + ret = -ENOTSUPP;
> oh, that one you can ignore @jsarha. There is no consensus in maintainer circles on this checkpatch warning so we keep using ENOTSUPP > > if it is confusing...