jsanin comments

Results 4 comments of


                                            jsanin

Generate clients, fakeclients, informers and listers for go consumers of cartographer to import

hey @rawlingsj I am having issues trying this out because we are using Knative sample controller as based to create our controllers. It turns out that this project (cartographer) depends...

Generate clients, fakeclients, informers and listers for go consumers of cartographer to import

@rawlingsj thanks for the tip about `replace`. So it now compiles. For future reference this is what we add to our project: ``` replace ( github.com/vmware-tanzu/cartographer => github.com/rawlingsj/cartographer v0.0.7-0.20211117083742-bdefc96eef5c k8s.io/api...

Generate clients, fakeclients, informers and listers for go consumers of cartographer to import

Hi there. I have been busy getting some things done before the code freeze. I should be able to review this by Monday. Sorry for the delay

Defective revision can lead to pods never being removed

[PR 14573](https://github.com/knative/serving/pull/14573) aims to fix this issue. The proposed fix is based on the [TimeoutSeconds field in the Revision](https://github.com/knative/serving/blob/0c2d16bf44c332397ebc73a36b9d5544d3f97610/pkg/apis/serving/v1/revision_types.go#L90). After this `timeoutSeconds` has gone by there should not be any...