java-cookie

java-cookie copied to clipboard

Fix #14: Decoding fails when two encoded characters appear one after another

14

@FagnerMartinsBrack I accidentally did some small refactoring (simplifications) together with the fix, the actual fix for is in Cookies:316-323. Please review and merge, thanks! Resolves #14.

tholu

Implement the builder pattern to make the `Cookies.Attributes` immutable.

2

In js-cookie the attributes are specified using an Object Literal instance. In Java we can make a step forward and ensure that the passed attributes are not going to be...

FagnerMartinsBrack

New release

4

After merging #21, #22, #23 - a new release would be nice. @FagnerMartinsBrack

tholu

It does not comply with RFC since the space following the ; delimiter is optional. Ref https://tools.ietf.org/html/rfc6265#section-2.2 Could be changed to split( "; ?" ); ; matches the character ;...

mvkendall

- Integration test for setting and reading simple/JSON cookies - Fix test by merging the fix for #14 - Fix needs to be verified with `mvn verify`, as integration tests...

tholu

JSON generates cookie that it cannot read

4

LoginUtils.PageStyleCookie cookie = new LoginUtils.PageStyleCookie(lefLogo, rightLogo, css); cookies.set(LoginUtils.COOKIE_STYLES, cookie); PageStyleCookie stylesCookie = cookies.get(COOKIE_STYLES, PageStyleCookie.class); Failed to parse JSON of cookie: {"logoLeft":"aa.png"%2C"logoRight":"aa.png"%2C"style":"main.css"}

literakl

Decoding sometimes fails when two encoded characters appear one after another.

6

The `Cookies.decode( String encoded )` method sometimes fails to properly decode the given string when two encoded characters appear one after another. For example, the decoding fails for the given...

davidklebanoff

Extending the get and set methods to get from response and set to request

18

In Cookies.java the set(String name, String Value, AttributesDefinition attributes); will set the cookie using setCookie(String cookieValue, HttpServletResponse response); which will use the 'Set-Cookie' header. This is for the usecase when...

roelstorms

This have come up on https://github.com/js-cookie/java-cookie/issues/10#issuecomment-166774238

FagnerMartinsBrack

Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.11.2 to 2.12.6.1. Commits See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter...

dependabot[bot]