Fix #14: Decoding fails when two encoded characters appear one after another

[tholu]

@FagnerMartinsBrack I accidentally did some small refactoring (simplifications) together with the fix, the actual fix for is in Cookies:316-323.

Please review and merge, thanks!

Resolves #14.

[FagnerMartinsBrack]

The integration test with js-cookie fails when I checkout 9e305c9:

Are you getting the same error?

[tholu]

@FagnerMartinsBrack Thanks for checking that, I can reproduce it and need to look into it.

[JevinMenezes]

It's been a while here for this PR, wish it could be closed any time soon.

[FagnerMartinsBrack]

@JevinMenezes If the OP is not continuing to work on this for more than a year then I believe it can be closed.

[tholu]

@JevinMenezes @FagnerMartinsBrack Thanks for the reminder! I'll try to finish it soon.

[tholu]

@JevinMenezes I fixed the test, but Travis is not running anymore?

[JevinMenezes]

@FagnerMartinsBrack Travis builds for this repository have stopped in travis-ci.org and this repo needs to be migrated to travis-ci.com. Can we migrate java-cookie repo to travis-ci.com ?

[FagnerMartinsBrack]

@JevinMenezes yes what do you want me to do?

[JevinMenezes]

Just wanted to ask whether I can approve & request this for organization js-cookie, @FagnerMartinsBrack (I believed organization owner could approve this)

[FagnerMartinsBrack]

If it needs to be migrated or it doesn't work then go for it. can you do it yourselfot do you need some permissions?

On Sun, 31 Oct 2021 at 18:15, Jevin Menezes @.***> wrote:

Just wanted to ask whether I can approve & request this for organization js-cookie, [image: Capture] https://user-images.githubusercontent.com/13982269/139572546-1221c590-a2b0-43e7-82c5-5b11a5ff5f62.PNG @FagnerMartinsBrack https://github.com/FagnerMartinsBrack

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/js-cookie/java-cookie/pull/21#issuecomment-955649452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMCEOJOSUOF3ORVDG6YALUJTUINANCNFSM4G22ZRKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- https://about.me/fagnerbrack?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

Fagner Brack [image: https://]about.me/fagnerbrack https://about.me/fagnerbrack?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

[FagnerMartinsBrack]

@JevinMenezes I received the email and just approved it, let me know if you need anything else

[JevinMenezes]

@FagnerMartinsBrack thanks, seems like an admin privilege user can migrate the java-cookie repo and I'm unable to select the repo for migrating to travis-ci.com, would you be able to do it, thanks again ,

[FagnerMartinsBrack]

Done @JevinMenezes

[tholu]

@JevinMenezes Can this be merged now? I'll have to fix conflicts in #23 afterwards.