Joshua O'Madadhain

Results 89 comments of Joshua O'Madadhain

Good catch--thanks! However, you need to use `LinkedHashSet` and `LinkedHashMap` to guarantee that it would work in general, because the `Tree` classes assume that the nodes have a natural ordering....

Hmm. I don't have time to look into this tonight in detail, but let me know if you spot the problem. What's the error you're seeing?

Thanks for your suggested fix. It turns out that there was an additional fix needed, which I supplied in #263, so this patch is no longer needed, but I appreciate...

My biases are basically a stronger version of @jbduncan 's; in my case I'm familiar with Truth but haven't used AssertJ. Plus I know the Truth folks personally in case...

The Layout algorithms can be (and in some cases are) used by some people who want a layout algorithm but want to do their own rendering. Layout and rendering can,...

@jbduncan you're not wrong. :) If you'd like to take a stab at a design for that, go for it. I'm currently wrapped up in other elements (specifically, stuff related...

I agree that we should have our own internal versions of `Dimension` and `Point.2D` to break the algorithms' package dependency on AWT/Swing, and that it should be the visualization package's...

@wumpz I hacked GraphMLReader/Writer together probably ~10 years back; GraphMLReader2 was a donation. To be entirely honest I don't use GraphML (nor XML in general) myself much; I didn't know...

I'm not entirely sure what you're proposing that a `Layout` would look like in this proposed architecture. I guess you're talking about splitting `Layout` into two types: one for the...

@jbduncan, I'm responding to your comment first because it's easiest. :) The short version is: I should not have put those two sentences in the same paragraph, because I did...