John Rodriguez
John Rodriguez
Took another look at this. The issue is that BridgeContext inherits from Context, not ContextWrapper, therefore `dagger.hilt.android.internal.Contexts` is unable to find the application context here: https://github.com/google/dagger/blob/a8581e0a62b7cb3d1f5a13da26a8f40e22aad3d0/java/dagger/hilt/android/internal/Contexts.java One option might be...
Tracked here: https://issuetracker.google.com/issues/342557695
@ZacSweers mind: 1) rebasing and 2) inlining `configureVariant` for a better diff before another review?
> Yes, [layoutlib v16.x.x ](https://github.com/cashapp/paparazzi/pull/2066)includes the missing method in `DisplayManagerGlobal` Specifically, v16.1.x does (not v16.0.x). https://android.googlesource.com/platform/frameworks/layoutlib/+/dba3b4a0d1afdb134af8f9b948049f627be1122b%5E%21/#F0
Closing as wontfix, since this is a user environment issue, and there's a suitable workaround (thanks @rahnamaMo!)
> So this blocks us from going to 1.3.4, cause we need this in our CI. Have you experimented with values for [maxPercentDifference](https://github.com/cashapp/paparazzi/blob/master/paparazzi/src/main/java/app/cash/paparazzi/Paparazzi.kt#L36)?
> As @VirtualParticle rightfully mentioned: > > > To deal with the higher difference scenarios, we'd have to set the maxPercentDifference to be high enough where actual bugs may be...
> Can we expect a fix for this? I'm not sure what the root cause is yet, so hard to promise a fix yet, but I'll be investigating this issue...
FYI, still investigating, but wanted to share notes: For this investigation, I've been using the snippet provided in https://github.com/cashapp/paparazzi/issues/1465#issue-2326059848 and had already been investigating before @gabrielittner's [simpler repro here](https://github.com/cashapp/paparazzi/issues/1465#issuecomment-2179960990). First,...
@gabrielittner one theory I also wanted to try/dismiss was whether I messed up the Iguana migration. I recall you had a commit where you had tweaked the `withTime()` argument with...