John Rodriguez

Results 163 comments of John Rodriguez

It might be helpful to know that we have discussed moving the current file naming scheme into, say, a json descriptor, and making the filename more of a hash (similar...

Without a sample project, it's difficult to know if this is identical to #1124 or a byproduct of the error in #1231. If the latter, that's now fixed now that...

- [x] Wait for next ksp release?

Paparazzi relies on the [Android Gradle Plugin APIs](https://github.com/cashapp/paparazzi/commit/04812bb928ce1e720e5aad5f839db2b488f49c90) to learn about generated resources. I took only a quick look at the [accompanying gradle plugin](https://github.com/icerockdev/moko-resources/blob/4fefda5f35ad89e4170f56779ff70fbae42720cb/resources-generator/src/main/kotlin/dev/icerock/gradle/MultiplatformResourcesPlugin.kt) and it looks like it doesn't...

Thanks for the heads up. I've disabled publishing for now, vs adding the pom details for publication as you did here.

> @jrodbx any reason for not publishing test reports to GHA artifacts? Mistake. https://github.com/cashapp/paparazzi/pull/687

> @jrodbx I think I need some help figuring out why windows tests are failing. MacOS ``` file: /Users/jrod/Development/paparazzi/paparazzi/paparazzi-gradle-plugin/src/test/projects/custom-fonts-code/build/intermediates/merged_res/debug/font/cashmarket_medium.xml ``` Windows ``` file: D:\a\paparazzi\paparazzi\paparazzi\paparazzi-gradle-plugin\src\test\projects\custom-fonts-code\build\intermediates\merged_res\debug\font\cashmarket_medium.xml ``` Repro branch: https://github.com/cashapp/paparazzi/tree/jrod/2023-01-18/asm

I think reverting the latest changes and instead figuring out if there's a way to pass in the path in a platform-agnostic way, might work better? Also, does this issue...

Can you provide a repro project? Otherwise, I'm afraid there's not enough to work with based on this issue.

Closing. Please refile with a sample project, if this persists.