Jörg Riesmeier

Results 26 comments of Jörg Riesmeier

Thank you for your report. As far as I can see, DCMTK_ENABLE_STL is a CMake option that can either be ON or OFF. Also, your proposed patch changes the way...

I am not a CMake expert and also not the DCMTK developer who introduced these `DCMTK_ENABLE_STL_` "options", but in fact these CMake variables are strings and no options. This is...

@offis-jas Could you please check this pull request (and this conversation)? Thank you.

@tsondergaard Sorry for the late reply. It's now up to @offis-jas to test the proposed changes in detail and commit them to the "testing branch" (if this makes sense).

Thank you for the patch. As far as I can see, the CharLS 2.0 library itself is missing, right? So, how did you replace the DCMTK-specific version of CharLS 1.0...

OK, thank you for further explanations. So, this means we cannot apply your patch before we've switched to CharLS 2.0 (which will not happen soon because version 2.0 requires C++11...

Thank you for confirming this. I've added a note to the above-mentioned feature request #344. Debian people still seem to have problems with newer versions of the CharLS library.

Maybe, you should contact Mathieu Malaterre (@malaterre) regarding this issue. He is also the author of gdcm.

According to [Feature #344](https://support.dcmtk.org/redmine/issues/344#note-5): > The implementation strategy for DCMTK decided by the team will be to keep the internal CharLS version available in DCMTK (for platforms where CharLS is...

Thank you for your contribution! Not sure whether we will apply the patch directly (or adjust it a little bit...) but in any case you'll be mentioned as the original...