John Henderson

Adding the `returnPresentation` option to presentation/verify. Implements #207 . In order to do this, separated out `VerifyPresentationOptions` and `VerifyCredentialResult` because credential has `verifiedCredential` and presentation has `verifiedPresentation`.

Typescript errors in question route

2

When running `lint`, type errors are reported: ``` ❯ npm run lint > lint > tsc && npm run prettier && npm run eslint app/routes/questions.$questionId.$.tsx:64:10 - error TS2339: Property 'question'...

chore(storybook preview): use RemixStub decorator

1

Fixes #452 Using RemixStub in order to provide necessary remix context https://blog.sentiero.digital/how-to-run-remix-link-component-in-storybook Also, remove BrowserRouter as it was causing double router and isn't required for Remix https://remix.run/docs/en/main/guides/migrating-react-router-app#adapting-your-existing-app-code

Fix Article in Storybook

1

Article in Storybook is not rendering and displaying the following error: ``` useSubmit must be used within a data router. See https://reactrouter.com/routers/picking-a-router. ``` 

PRs from forked branches can't run CI tests

1

Because PRs from repo forks don't have access to GitHub secrets (see [GHA docs](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflows-in-forked-repositories)), PRs from forked repos won't be able to pass the CI currently. This is because the...

Typescript implementation

5

Is anyone aware of any efforts towards typescript implementation of this spec? I see that none have been added to this PR https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/36 but thought I would ask in case...

I believe that because the [Workflows and Exchanges](https://w3c-ccg.github.io/vc-api/#workflows-and-exchanges) section has been added, the exchange section from the Presenting could be removed. I propose the following be removed: - [Inititate Exchange](https://w3c-ccg.github.io/vc-api/#initiate-exchange)...

I believe the type signature of the `W3cCredentialsApi` [verifyCredential method](https://github.com/openwallet-foundation/credo-ts/blob/855d4ab04de317dab0f0e2a31fee6ba44750537f/packages/core/src/modules/vc/W3cCredentialsApi.ts#L60) is incorrect. Code as follows has a TS compilation error: ```typescript const w3cVerifyCredentialOptions: W3cVerifyCredentialOptions = { credential: W3cJsonLdVerifiableCredential.fromJson(vc) }; const...

The VC data model (both [v1.1](https://www.w3.org/TR/vc-data-model/#presentations-0) and [v2.0](https://w3c.github.io/vc-data-model/#verifiable-presentations)) allow the `verifiableCredential` property on a VerifiablePresentation to be optional. There are cases where it may not be present, such as an...

Clarify the distinction between exchangeId and localExchangeId

3

When calling [Create Exchange](https://w3c-ccg.github.io/vc-api/#create-exchange), an `exchangeId` is returned. However, the [Participate in an Exchange](https://w3c-ccg.github.io/vc-api/#participate-in-an-exchange) endpoint has a `localExchangeId` URL path parameter. Looking at the [Exchange Example](https://w3c-ccg.github.io/vc-api/#exchange-examples), my assumption is that...