jrhee17
jrhee17
> In your poc, we couldn't apply the mapping by HttpStatus in RestClient. I thought we could do something like the following: ``` final ResponseEntity res2 = RestClient.of(server.httpUri()).get("/") .execute(ResponseAs.blocking() .andThenJson(MyError.class,...
Oops, approved by mistake 😅
> After I think about it in many ways, I still think users have to create and manage their own IDs. Sure, I'm not sure what the UI will look...
> It may be difficult to detect bugs and handle them if this change was released along with the mirroring UI, so I wanted to release it separately. > Do...
> I think we also need to update RouteDecoratingService. I guess we don't need to do this yet since 1) we only check `HttpService#options` when the server is being built...
Gentle ping 🙏
Is this PR re-ready for review? I prefer at least the CI be passing before reviewing since it is time/effort consuming on my end as well.
> I will update this PR over the weekend and let you know. I saw this comment late: https://github.com/line/armeria/pull/5580#issuecomment-2194482724 Let's wait to see if @ikhoon is done updating before proceeding...
> I was wondering if you want to check the code again or if you already have done. I think it should be fine to go ahead as I don't...
I believe as a starting point for this issue, it is enough to - Add a field related to TLS handshake at `ClientConnectionTimingsBuilder` - We can worry about generalizing and...