Juliette

Results 2038 comments of Juliette

Thanks for that link, I'll read up on the discussion. > In the meantime I'd just pick the paradigm that makes the most sense to you and stick to it,...

> I'd probably opt for disallowing importing more than one thing per use statement. That would effectively also ban the use of group use statements ?

> Also, it should be noted that php-cs-fixer does force the opening tag to be in lowercase, whilst phpcs does not. I know Greg was always very very strict about...

@vjik As far as I know, that rule is about the _type_ of open tags and basically forbids the use of `

> The RFC used inline and no one objected at that time. Sorry, but that really is a non-argument. People read and evaluate RFCs for the _functionality_ which is being...

FYI: once this PR has been merged (providing it is accepted), I have a commit ready to turn on testing on PHP 8.2/8.3/8.4 in CI.

> Historically we've kept PHP5.6 support around longer due to WordPress' extended support for it. @gRegorLove Much appreciated! Just so you know, WP has dropped support for PHP < 7.2...

Rebased without significant changes to get passed the merge conflict.

> The [test failure](https://github.com/WordPress/WordPress-Coding-Standards/actions/runs/15548378010/job/43796829373?pr=2530) looks unrelated to the changes in this PR. Correct. > @jrfnl We pull in PHPCSUtils `develop` for the tests - maybe [PHPCSStandards/PHPCSUtils#677](https://github.com/PHPCSStandards/PHPCSUtils/pull/677) or similar upstream is...

> This is actually related to a change in PHP 8.4, which will be supported in PHPCS 4.x and which PHPCSUtils 1.1.0 will support for both PHPCS 3.x as well...