Juliette

Results 2038 comments of Juliette

For reference for anyone coming across this PR and wanting to understand the larger context: * https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Version-4.0-User-Upgrade-Guide#my-scans-are-failing-on-a-no-files-were-checked-error * https://github.com/squizlabs/PHP_CodeSniffer/issues/1595 * https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/1023

> The first array should not be detected as multi-line. Why ? It clearly is a multi-line array. I.e. the opener is not on the same line as the closer.

> To conclude my problem is not about the definition of single or multi-line arrays (should I reword my post?), but about this weird trailing comma in the first code...

@DanielEScherzer Thank you for working on this proposal and yes, opening a dedicated issue, like this, to discuss proposed implementation details for the more complex syntaxes is exactly as intended...

@DanielEScherzer Thank you for your thoughts on this, but I don't think this is the way to go and I fear that the currently proposed solution for `getMemberProperties()` and `getMethodParameters()`...

I've now opened PR #1116 to implement the changes to the `File` methods. @DanielEScherzer would you like to review ?

I've now also opened PRs to add support for asym visibility to all sniffs which I could find would need it. Hope I didn't miss any. PRs are all linked...

Rebased without changes to get passed an imaginary merge conflict.

I agree that it would be a good thing™ for this array to be better documented. In the PHPCS 2.x branch, the array was documented in the `File` class and,...

While the documentation added here is _strictly_ correct, IMO it is misleading as the `$tokens` array is enhanced with numerous other keys after this initial run and those other keys...