Jean-Rémy Falleri

Results 72 comments of Jean-Rémy Falleri

It seems to be the case also for the css filter

Hi @monperrus, Currently it's not possible. We have a JSON differ compliant with the RFC Json patch here : https://github.com/caohanyang/json_diff_rfc6902 (beware it's not maintained anymore). Also there is a tree...

OK don't hesitate to tell me how it works with diffson, AFAIK it seems to be using sequence algorithms (LCS, Patience)? FYI we have a small benchmark in our publication...

Hi! Currently textdiff accept only two files as arguments (source and destination files). However it could be nice to have a whole directory diff such as webdiff. I am not...

Hi, there is the DirectoryComparator (https://github.com/GumTreeDiff/gumtree/blob/main/core/src/main/java/com/github/gumtreediff/io/DirectoryComparator.java) that does exactly that, but it is not associated to a CLI command 😢 Then we could use this inside the textdiff command, but...

Hi and thanks for the bug report and PR! However, is it normal that UnknownType has a null range or is it a bug from Javaparser? Cheers.

Thanks for the explanation, very useful! I guess the next question is therefore : do we need this node in the tree or do we ignore it? If there is...

> I agree, a node with no lexical representation is not of interest for an AST differencing tool. Do you want to try a PR ? Cheers!

OK thanks, I was not sure that this PR was ignoring the UnknownType nodes! I will try it out.

I believe @monperrus is asking you to see if the behavior is the same. I know what is causing the problem : extends / implements is not part of the...