Joshua C. Randall

Results 52 comments of Joshua C. Randall

Please note that the `LICENSE` file in this PR reads as follows: ``` Copyright (c) 2014 John Gallagher Copyright (c) 2019 Genomics plc Permission is hereby granted, free of charge,...

> So, for the patch in the branch that hasn't landed yet, I don't have strong feelings about what to do about it, although it's clear removing it does violate...

I have now moved the "Genomics plc" attribution out of `LICENSE` and into an explanatory note in `CONTRIBUTORS.md`

I'm working on fixing the test failures. It looks like there are some issues with exotic combinations of feature flags.

> > My suggestion for a compromise would be to add a CONTRIBUTORS file [...] > > That looks like a great solution! I've closed the other PR. Can we...

> Commit history has been lost !!! > I am afraid you will have to restart from @phiresky branch. History has been restored. Apologies - I had squashed it all...

> The "dummy" extensions in the code are just example extensions, right? Would it make sense to rename all instances of "dummy" to "example" or "demo" or similar, to avoid...

> The "dummy" extensions in the code are just example extensions, right? Would it make sense to rename all instances of "dummy" to "example" or "demo" or similar, to avoid...

@gwenn I addressed the review changes you requested on 7th March - could you please re-review? I've now also updated against the default branch for v0.26.2 and fixed all issues...

> > @gwenn I addressed the review changes you requested on 7th March - could you please re-review? I've now also updated against the default branch for v0.26.2 and fixed...