JP Simard

Results 706 comments of JP Simard

> If anyone knows of a way of tricking Xcode into running a shell script within a “compile sources” build phase, I think that would get us most of the...

> I thought of replacing the `swift` executable with a custom executable that does its own thing and then calls the real `swift`. It would probably work, but that kind...

It _might_ actually be possible to render fix-its from external build phases: https://clang.llvm.org/docs/UsersManual.html#cmdoption-fdiagnostics-parseable-fixits I'm not sure because I haven't been able to get anything in that format or variations thereof...

Looking at this again for the first time in a while, there's a few things I'd like the author(s) to think through before we can consider something like this, which...

As I was reviewing this, I was making some edits, which I always find helpful in understand code, they may or may not be helpful to anyone who's interested in...

Nice proof of concept! I'm supportive of something like this, but would like to see it in use before merging it. We have a handful of SwiftSyntax-based rules, maybe one...

Apologies for the delay in getting back to you. If the main goal of introducing this DSL is to make it easier to build SwiftSyntax-based rules by removing ceremony I...

As an exploration, I've pushed a prototype of what some SwiftSyntax/SwiftLint convenience helpers could look like in https://github.com/realm/SwiftLint/pull/4126 It allows rules to provide visitors/rewriters and the framework takes care of...

What's your `Package.swift`? Based on the Xcode error messages, it's telling you Xcode is trying to build SwiftLint to run on an iOS target, which it of course won't work,...

That won't work, that'll try to build a target with the SwiftLint macOS binary for an iOS target, which won't work for the reasons I explained above.